lkml.org 
[lkml]   [2009]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH V2 0/7] swiotlb: changes for powerpc/highmem
    From
    On Fri,  3 Apr 2009 20:56:42 -0500
    Becky Bruce <beckyb@kernel.crashing.org> wrote:

    > This is v2 of a series of fairly minor patches that get swiotlb
    > working on 32-bit powerpc systems with HIGHMEM, plus some cleanup
    > of the outdated comments in the code. I've made a couple of things
    > weak that ppc needs to override, and have changed the prototypes
    > for a couple of functions to include the hwdev pointer, which
    > we need to ppc to convert bus addresses to and from phys/virt
    > addresses. I've also fixed a build warning I've been seeing on
    > ppc.
    >
    > In response to commentary on the previous series, I've also
    > refactored the code a bit, altough I did this slightly
    > differently than was suggested because I noticed we could use the
    > new helper function in 2 places instead of one. I've reformatted
    > a bit of code based on commentary as well.
    >
    > I have not tested this in any way on any non-ppc platforms,
    > so commentary/testing from x86/ia64 folks is, once again,
    > greatly appreciated.
    >
    > I'm going to be offline for the next week, but will respond to
    > commentary as soon as I return.
    >
    > Cheers,
    > Becky
    >
    > diffstat:
    > arch/x86/kernel/pci-swiotlb.c | 2 +-
    > include/linux/swiotlb.h | 3 +-
    > lib/swiotlb.c | 115 ++++++++++++++++++++++-------------------
    > 3 files changed, 64 insertions(+), 56 deletions(-)

    I have a minor comment on 5/7 but the rest looks fine to me.


    \
     
     \ /
      Last update: 2009-04-07 04:27    [W:0.022 / U:33.880 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site