lkml.org 
[lkml]   [2009]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: intel-iommu: Add for_each_iommu() and for_each_active_iommu() macros


    On Mon, 6 Apr 2009, David Woodhouse wrote:

    > On Mon, 2009-04-06 at 18:09 -0700, David Woodhouse wrote:
    > >
    > > I'm unconvinced by the fix -- can we find a way to fix the if() macro so
    > > that normal (if fugly) C code like this doesn't doesn't need this kind
    > > of workaround?
    >
    > Something like this perhaps? I'd reformat it but dinner calls...

    Use emacs Ctrl-c / ;-)

    >
    > diff --git a/include/linux/compiler.h b/include/linux/compiler.h
    > index 6faa7e5..1da2e72 100644
    > --- a/include/linux/compiler.h
    > +++ b/include/linux/compiler.h
    > @@ -114,7 +114,7 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
    > * "Define 'is'", Bill Clinton
    > * "Define 'if'", Steven Rostedt
    > */
    > -#define if(cond) if (__builtin_constant_p((cond)) ? !!(cond) : \
    > +#define if(cond, ...) if (__builtin_constant_p((cond, ## __VA_ARGS__)) ? !!(cond, ## __VA_ARGS__) : \
    > ({ \
    > int ______r; \
    > static struct ftrace_branch_data \
    > @@ -125,7 +125,7 @@ void ftrace_likely_update(struct ftrace_branch_data *f, int val, int expect);
    > .file = __FILE__, \
    > .line = __LINE__, \
    > }; \
    > - ______r = !!(cond); \
    > + ______r = !!(cond, ## __VA_ARGS__); \
    > ______f.miss_hit[______r]++; \
    > ______r; \
    > }))
    >

    If this works then (after reformating)

    Acked-by: Steven Rostedt <rostedt@goodmis.org>

    -- Steve



    \
     
     \ /
      Last update: 2009-04-07 03:31    [W:0.020 / U:0.708 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site