Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH] xsysace: Fix dereferencing of cf_id after hd_driveid removal | Date | Mon, 6 Apr 2009 22:58:10 +0200 |
| |
On Sunday 05 April 2009, Grant Likely wrote: > From: Grant Likely <grant.likely@secretlab.ca> > > Commit 4aaf2fec718f6fbf38668edf733a0ab09a49cab1 (xsysace: make it > 'struct hd_driveid'-free) converted the cf_id member of 'struct > ace_device' from a 'struct hd_driveid' to a u16 array. However, > references to the base of the structure were still using the '&' > operator. When the address was used with the ata_id_u32() macro, the > compiler used the size of the entire array instead of sizeof(u16) to > calculate the offset from the base address. > > This patch removes the use of the '&' operator from all references of > cf_id to fix the bug and remove future confusion. > > Signed-off-by: Grant Likely <grant.likely@secretlab.ca> > CC: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Thanks for quickly spotting & fixing it.
| |