lkml.org 
[lkml]   [2009]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/8] block: fsync_buffers_list() should use SWRITE_SYNC_PLUG
    Date
    Then it can submit all the buffers without unplugging for each one.
    We will kick off the pending IO if we come across a new address space.

    Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
    ---
    fs/buffer.c | 20 ++++++++++++++++----
    1 files changed, 16 insertions(+), 4 deletions(-)

    diff --git a/fs/buffer.c b/fs/buffer.c
    index 5d55a89..43afaa5 100644
    --- a/fs/buffer.c
    +++ b/fs/buffer.c
    @@ -737,7 +737,7 @@ static int fsync_buffers_list(spinlock_t *lock, struct list_head *list)
    {
    struct buffer_head *bh;
    struct list_head tmp;
    - struct address_space *mapping;
    + struct address_space *mapping, *prev_mapping = NULL;
    int err = 0, err2;

    INIT_LIST_HEAD(&tmp);
    @@ -762,7 +762,18 @@ static int fsync_buffers_list(spinlock_t *lock, struct list_head *list)
    * contents - it is a noop if I/O is still in
    * flight on potentially older contents.
    */
    - ll_rw_block(SWRITE_SYNC, 1, &bh);
    + ll_rw_block(SWRITE_SYNC_PLUG, 1, &bh);
    +
    + /*
    + * Kick off IO for the previous mapping. Note
    + * that we will not run the very last mapping,
    + * wait_on_buffer() will do that for us
    + * through sync_buffer().
    + */
    + if (prev_mapping && prev_mapping != mapping)
    + blk_run_address_space(prev_mapping);
    + prev_mapping = mapping;
    +
    brelse(bh);
    spin_lock(lock);
    }
    @@ -2957,12 +2968,13 @@ void ll_rw_block(int rw, int nr, struct buffer_head *bhs[])
    for (i = 0; i < nr; i++) {
    struct buffer_head *bh = bhs[i];

    - if (rw == SWRITE || rw == SWRITE_SYNC)
    + if (rw == SWRITE || rw == SWRITE_SYNC || rw == SWRITE_SYNC_PLUG)
    lock_buffer(bh);
    else if (!trylock_buffer(bh))
    continue;

    - if (rw == WRITE || rw == SWRITE || rw == SWRITE_SYNC) {
    + if (rw == WRITE || rw == SWRITE || rw == SWRITE_SYNC ||
    + rw == SWRITE_SYNC_PLUG) {
    if (test_clear_buffer_dirty(bh)) {
    bh->b_end_io = end_buffer_write_sync;
    get_bh(bh);
    --
    1.6.2.1.423.g442d


    \
     
     \ /
      Last update: 2009-04-06 14:51    [W:4.497 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site