Messages in this thread | | | Subject | Re: ath9k becon loss messages | From | Kalle Valo <> | Date | Sun, 05 Apr 2009 13:03:54 +0300 |
| |
Michael Buesch <mb@bu3sch.de> writes:
> On Sunday 05 April 2009 11:29:38 Michael Buesch wrote: > >> I think this message should only show if >> CONFIG_MAC80211_VERBOSE_DEBUG is set. It's kind of expected that we >> lose a beacon once in a while, so we shouldn't print verbose >> messages to the kernel log (even if they are KERN_DEBUG). >> >> And besides that, I think one can easily remotely trigger this >> message and flood the logs. So it should probably _also_ be >> ratelimited. > > Something like this:
I agree, the message confuses the users and creates way too much problems. Your patch is a good solution, the message is still useful for the driver developers.
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Reviewed-by: Kalle Valo <kalle.valo@iki.fi>
-- Kalle Valo
| |