lkml.org 
[lkml]   [2009]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] snd: aica - fix annoying compiler warning
    At Thu, 02 Apr 2009 00:41:50 +0100,
    Adrian McMenamin wrote:
    >
    > On Tue, 2009-03-31 at 08:10 +0900, Paul Mundt wrote:
    > > On Mon, Mar 16, 2009 at 08:59:20AM +0100, Takashi Iwai wrote:
    > > > At Mon, 16 Mar 2009 07:54:09 +0000,
    > > > Adrian McMenamin wrote:
    > > > >
    > > > > On Mon, 2009-03-16 at 07:31 +0100, Takashi Iwai wrote:
    > > > > > At Sun, 15 Mar 2009 22:05:40 +0000,
    > > > > > Adrian McMenamin wrote:
    > > > > > >
    > > > > > > Cast pointer to data member of struct firmware as a void to end an
    > > > > > > annoying compiler warning.
    > > > > > >
    > > > > > > fix annoying compiler warning
    > > > > > >
    > > > > > > Signed-off-by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
    > > > > > > ---
    > > > > > >
    > > > > > > diff --git a/sound/sh/aica.c b/sound/sh/aica.c
    > > > > > > index 7c920f3..822b119 100644
    > > > > > > --- a/sound/sh/aica.c
    > > > > > > +++ b/sound/sh/aica.c
    > > > > > > @@ -567,7 +567,7 @@ static int load_aica_firmware(void)
    > > > > > > return err;
    > > > > > > /* write firware into memory */
    > > > > > > spu_disable();
    > > > > > > - spu_memload(0, fw_entry->data, fw_entry->size);
    > > > > > > + spu_memload(0, (void *)fw_entry->data, fw_entry->size);
    > > > > >
    > > > > > IMO, it's better to fix spu_memload() to take const pointer instead of
    > > > > > cast.
    > > > > >
    > > > >
    > > > > If that's what you want I can do that but it adds to kernel bloat by
    > > > > having two functions essentially do the same thing.
    > > >
    > > > I meant a fix like below...
    > > >
    > > Is anything happening with this, or should I just ignore it?
    > >
    >
    > I though Takashi's fix was fine/obvious but it doesn't appear to have
    > been pushed upstream (yet?)

    Well, then it'd be appreciated if you repost your patch with my fix.

    thanks,

    Takashi



    \
     
     \ /
      Last update: 2009-04-06 03:31    [W:0.026 / U:0.536 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site