lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] cpuacct: VIRT_CPU_ACCOUNTING don't prevent percpu cputime count
* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> [2009-04-30 17:52:16]:

> > > > for (i = 0; i < CPUACCT_STAT_NSTATS; i++) {
> > > > - s64 val = percpu_counter_read(&ca->cpustat[i]);
> > > > + s64 val = percpu_counter_sum(&ca->cpustat[i]);
> > > > val = cputime64_to_clock_t(val);
> > > > cb->fill(cb, cpuacct_stat_desc[i], val);
> > > > }
> > >
> > > What do the test results look like with this? I'll see if I can find
> > > some time to test this patch. On a patch read level this seems much better
> > > to me, Peter?
> >
> > I don't really fancy percpu_counter_sum() usage. I'm thinking its ok to
> > degrate accuracy on larger machines and simply use
> > percpu_counter_read().
>
> I have same opinion with peter. Balbir, What do you think?
>

Sure, but the larger the delta gets, the less useful the metric gets
:) I am OK with going back to percpu_counter_read() if that is the
consensus.

--
Balbir


\
 
 \ /
  Last update: 2009-04-30 11:05    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site