Messages in this thread | | | Date | Thu, 30 Apr 2009 23:11:52 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH 1/3] ring-buffer: add counters for commit overrun and nmi dropped entries |
| |
On Thu, 30 Apr 2009, Andrew Morton wrote:
> On Thu, 30 Apr 2009 22:22:11 -0400 Steven Rostedt <rostedt@goodmis.org> wrote: > > > +unsigned long ring_buffer_nmi_dropped_cpu(struct ring_buffer *buffer, int cpu) > > +{ > > + struct ring_buffer_per_cpu *cpu_buffer; > > + unsigned long ret; > > + > > + if (!cpumask_test_cpu(cpu, buffer->cpumask)) > > + return 0; > > + > > + cpu_buffer = buffer->buffers[cpu]; > > + ret = cpu_buffer->nmi_dropped; > > + > > + return ret; > > +} > > +EXPORT_SYMBOL_GPL(ring_buffer_nmi_dropped_cpu); > > + > > +/** > > + * ring_buffer_commit_overrun_cpu - get the number of overruns caused by commits > > + * @buffer: The ring buffer > > + * @cpu: The per CPU buffer to get the number of overruns from > > + */ > > +unsigned long > > +ring_buffer_commit_overrun_cpu(struct ring_buffer *buffer, int cpu) > > +{ > > + struct ring_buffer_per_cpu *cpu_buffer; > > + unsigned long ret; > > + > > + if (!cpumask_test_cpu(cpu, buffer->cpumask)) > > + return 0; > > + > > + cpu_buffer = buffer->buffers[cpu]; > > + ret = cpu_buffer->commit_overrun; > > + > > + return ret; > > +} > > hm. Four functions in a row, all of which differ in but a single line. > > unsigned long > ring_buffer_commit_overrun_cpu(struct ring_buffer *buffer, int cpu) > { > return some_common_function(buffer, cpu)->commit_overrun; > } > > ?
But that actually takes thought. I like my cut and paste ;-)
-- Steve
| |