lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] ring-buffer: make cpu buffer entries counter atomic
On Thu, 30 Apr 2009 22:22:13 -0400 Steven Rostedt <rostedt@goodmis.org> wrote:

> @@ -405,7 +405,7 @@ struct ring_buffer_per_cpu {
> unsigned long nmi_dropped;
> unsigned long commit_overrun;
> unsigned long overrun;
> - unsigned long entries;
> + atomic_t entries;

This switches `entries' from unsigned-64-bit to signed-32-bit.

The signedness thing is just an unfortunate thing with atomic_t and probably
doesn't matter.

The change in size might or might not be a bug - that's for the person
who didn't document the data structure to work out ;)




/*
* head_page == tail_page && head == tail then buffer is empty.
*/
struct ring_buffer_per_cpu {
the comment refers to vaporfields?


\
 
 \ /
  Last update: 2009-05-01 05:13    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site