Messages in this thread Patch in this message | | | From | Frederic Weisbecker <> | Subject | [PATCH 3/6] kill-the-BKL/reiserfs: release write lock while rescheduling on prepare_for_delete_or_cut() | Date | Fri, 1 May 2009 04:44:19 +0200 |
| |
prepare_for_delete_or_cut() can process several types of items, including indirect items, ie: items which contain no file data but pointers to unformatted nodes scattering the datas of a file.
In this case it has to zero out these pointers to block numbers of unformatted nodes and release the bitmap from these block numbers.
It can take some time, so a rescheduling() is performed between each block processed. We can safely release the write lock while rescheduling(), like the bkl did, because the code checks just after if the item has moved after sleeping.
[ Impact: release the reiserfs write lock when it is not needed ]
Cc: Jeff Mahoney <jeffm@suse.com> Cc: Chris Mason <chris.mason@oracle.com> Cc: Alexander Beregalov <a.beregalov@gmail.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> --- fs/reiserfs/stree.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c index 6bd99a9..6ddcecb 100644 --- a/fs/reiserfs/stree.c +++ b/fs/reiserfs/stree.c @@ -1026,7 +1026,9 @@ static char prepare_for_delete_or_cut(struct reiserfs_transaction_handle *th, st reiserfs_free_block(th, inode, block, 1); } + reiserfs_write_unlock(sb); cond_resched(); + reiserfs_write_lock(sb); if (item_moved (&s_ih, path)) { need_re_search = 1; -- 1.6.2.3
| |