Messages in this thread | | | Date | Fri, 1 May 2009 08:51:50 +1000 (EST) | From | James Morris <> | Subject | Re: [PATCH] do_wait: do take security_task_wait() into account |
| |
On Wed, 29 Apr 2009, Oleg Nesterov wrote:
> I was never able to understand what should we actually do when > security_task_wait() fails, but the current code doesn't look right. > > If ->task_wait() returns the error, we update *notask_error correctly. > But then we either reap the child (despite the fact this was forbidden) > or clear *notask_error (and hide the securiy policy problems). > > This patch assumes that "stolen by ptrace" doesn't matter. If selinux > denies the child we should ignore it but make sure we report -EACCESS > instead of -ECHLD if there are no other eligible children. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next
-- James Morris <jmorris@namei.org>
| |