lkml.org 
[lkml]   [2009]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] USB: Provide USB boot device availability notification
Alan Stern wrote:

>>>+/* The mask of possible USB boot devices depends on what drivers and
>>>+ * options have been configured into the kernel. There are too many
>>>+ * USB network config options to list here, so just assume it is always
>>>+ * possible to have a USB network device.
>>>+ */
>>>+static int usb_bootdev_mask = 0
>>>+#ifdef CONFIG_USB_SERIAL_CONSOLE
>>>+ | BOOTDEV_CONSOLE_MASK
>>>+#endif
>>>+#if defined(CONFIG_USB_STORAGE) | defined(CONFIG_BLK_DEV_UB)

>> It should be ||, not bitwise | here, no?

> No, it should be bitwise |. The value being constructed is a union of
> disjoint mask bits.

I meant the #if line only. Although it shouldn't matter really...

> Alan Stern

WBR, Sergei


\
 
 \ /
  Last update: 2009-04-30 18:01    [W:0.330 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site