Messages in this thread | | | From | "Metzger, Markus T" <> | Date | Fri, 3 Apr 2009 07:46:30 +0100 | Subject | RE: [patch 14/18] x86, ds: use single debug store cpu configuration |
| |
>-----Original Message----- >From: Ingo Molnar [mailto:mingo@elte.hu] >Sent: Thursday, April 02, 2009 9:30 PM >To: Metzger, Markus T >Cc: tglx@linutronix.de; hpa@zytor.com; markus.t.metzger@gmail.com; roland@redhat.com; >eranian@googlemail.com; oleg@redhat.com; Villacis, Juan; ak@linux.jf.intel.com; linux- >kernel@vger.kernel.org >Subject: Re: [patch 14/18] x86, ds: use single debug store cpu configuration > > >* markus.t.metzger@intel.com <markus.t.metzger@intel.com> wrote: > >> Use a single configuration for all cpus. >> > >> @@ -1291,11 +1290,15 @@ ds_configure(const struct ds_configurati >> printk("bts/pebs record: %u/%u bytes\n", >> ds_cfg.sizeof_rec[ds_bts], ds_cfg.sizeof_rec[ds_pebs]); >> >> - WARN_ON_ONCE(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field)); >> + WARN_ON(MAX_SIZEOF_DS < (12 * ds_cfg.sizeof_ptr_field)); > >Why this change?
The function is only called once, now - for the boot cpu. The _ONCE is a nop. I thought its better to remove it, since it became redundant.
regards, markus.
> >Firstly, it was not declared in the changelog which is a no-no. > >Secondly, this is a bad change: we are more than content to have a >single such warning bootup - not dozens of it (on some large >system). > > Ingo --------------------------------------------------------------------- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen Germany Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer Registergericht: Muenchen HRB 47456 Ust.-IdNr. VAT Registration No.: DE129385895 Citibank Frankfurt (BLZ 502 109 00) 600119052
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.
| |