Messages in this thread |  | | | From | David Howells <> | | Subject | Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop | | Date | Fri, 03 Apr 2009 14:57:19 +0100 |
| |
Christoph Hellwig <hch@infradead.org> wrote:
> > + if (!aops->bmap) > > goto check_error; > > What are you doing using bmap? You really shouldn't call into it from > anywhere but FIBMAP. Yes, swap currently does but it's a major pain > in the neck and Peter has been working on a proper interface for swap > for a while.
Checking to see whether there's a hole in the file. If there's a hole, that represents data I need to fetch; if there isn't that represents data I have in the cache. I don't care _where_ the data is, only whether it exists or not.
David
|  |