lkml.org 
[lkml]   [2009]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop
    On Fri, Apr 03, 2009 at 10:41:38AM +0100, David Howells wrote:
    > + if (!aops->bmap)
    > goto check_error;

    What are you doing using bmap? You really shouldn't call into it from
    anywhere but FIBMAP. Yes, swap currently does but it's a major pain
    in the neck and Peter has been working on a proper interface for swap
    for a while.

    > + if (IS_ERR(file)) {
    > + ret = PTR_ERR(file);

    goto out_something;

    > + } else {
    > + ret = -EIO;
    > + if (file->f_op->write) {

    if (!file->f_op->write)
    goto out_fput;



    \
     
     \ /
      Last update: 2009-04-03 15:53    [W:0.023 / U:0.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site