lkml.org 
[lkml]   [2009]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -tip 0/6 V4] tracing: kprobe-based event tracer

* Avi Kivity <avi@redhat.com> wrote:

> Ingo Molnar wrote:
>>> kvm has three requirements not needed by kprobes:
>>> - it wants to execute instructions, not just decode them, including
>>> generating faults where appropriate
>>> - it is performance critical
>>> - it needs to support 16-bit, 32-bit, and 64-bit instructions simultaneously
>>>
>>> If an arch/x86/ decoder/emulator gives me these I'll gladly switch
>>> to it. x86_emulate.c is high on my list of most disliked code.
>>>
>>
>> Well, this has to be driven from the KVM side as the kprobes use
>> will only be for decoding so if it's modified from the kprobes
>> side the KVM-only functionality might regress.
>>
>> So ... we can do the library decoder for kprobes purposes, and
>> someone versed in the KVM emulator can then combine the two.
>
> Problem is, anyone versed in the kvm emulator will want to run as
> far away from this work as possible.

Are you suggesting that the KVM emulator should never have been
merged in the first place? ;-)

Anyway, we'll make sure the kprobes/library decoder is as clean as
possible - so it ought to be hackable and extensible without the
risk of permanent brain damage. Mmiotrace and kmemcheck has decoding
smarts too, and i think the sw-breakpoint injection code of KGDB
could use it as well - so there's broader utility in all this.

Ingo


\
 
 \ /
  Last update: 2009-04-03 14:31    [W:0.045 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site