lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/21] amd64_edac: add DRAM error injection logic using sysfs

    * Borislav Petkov <borislav.petkov@amd.com> wrote:

    > From: Doug Thompson <dougthompson@xmission.com>
    >
    > Signed-off-by: Doug Thompson <dougthompson@xmission.com>
    > Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
    > ---
    > drivers/edac/amd64_edac.c | 287 +++++++++++++++++++++++++++++++++++++++++++++
    > 1 files changed, 287 insertions(+), 0 deletions(-)
    >
    > diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
    > index b1a7e8c..4d1076f 100644
    > --- a/drivers/edac/amd64_edac.c
    > +++ b/drivers/edac/amd64_edac.c
    > @@ -4621,3 +4621,290 @@ static ssize_t amd64_hole_show(struct mem_ctl_info *mci, char *data)
    >
    > #endif /* DEBUG */
    >
    > +#ifdef CONFIG_EDAC_AMD64_OPTERON_ERROR_INJECTION

    this should be in a separate .c file under drivers/edac/amd64/.

    Introducing large #ifdef sections like that is not very clean. The
    amd64_edac.c file is _way_ too large at more than 5000 lines of
    code.

    Ingo


    \
     
     \ /
      Last update: 2009-04-29 20:21    [W:0.022 / U:59.140 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site