Messages in this thread | | | From | Jarod Wilson <> | Subject | Re: [PATCH] crypto: catch base cipher self-test failures in fips mode | Date | Wed, 29 Apr 2009 09:34:31 -0400 |
| |
On Wednesday 29 April 2009 09:26:46 Herbert Xu wrote: > On Wed, Apr 29, 2009 at 09:18:37AM -0400, Jarod Wilson wrote: > > On Wednesday 29 April 2009 09:15:07 Herbert Xu wrote: > > > On Tue, Apr 28, 2009 at 09:11:51PM -0400, Jarod Wilson wrote: > > > > > > > > +notest: > > > > + printk(KERN_INFO "alg: No test for %s (%s)\n", alg, driver); > > > > > > Can notest ever get here with rc != 0? > > > > Nope. > > So why do we need to move it?
Oh. Hrm. Upon looking a bit harder at it, I think the only reason would be if we wanted to print out a message claiming success in testing ctr(aes).
There's also a devious ulterior motive for this patch, which is to make the cryptodev tree look identical(er) to the Red Hat Enterprise Linux 5.x kernel tree w/in alg_test()...
-- Jarod Wilson jarod@redhat.com
| |