lkml.org 
[lkml]   [2009]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/10] ide-tape: don't initialize rq->sector for rw requests
    Date
    rq->sector is set to the tape->first_frame but it's never actually
    used and not even in the correct unit (512 byte sectors). Don't set
    it.

    [ Impact: cleanup ]

    Signed-off-by: Tejun Heo <tj@kernel.org>
    ---
    drivers/ide/ide-tape.c | 1 -
    1 files changed, 0 insertions(+), 1 deletions(-)

    diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
    index 8dfc688..7149224 100644
    --- a/drivers/ide/ide-tape.c
    +++ b/drivers/ide/ide-tape.c
    @@ -892,7 +892,6 @@ static int idetape_queue_rw_tail(ide_drive_t *drive, int cmd, int size)
    rq->cmd_type = REQ_TYPE_SPECIAL;
    rq->cmd[13] = cmd;
    rq->rq_disk = tape->disk;
    - rq->sector = tape->first_frame;

    if (size) {
    ret = blk_rq_map_kern(drive->queue, rq, tape->buf, size,
    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-04-29 11:23    [W:0.021 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site