Messages in this thread Patch in this message | | | From | Tejun Heo <> | Subject | [PATCH 02/14] block: don't init rq fields unnecessarily | Date | Tue, 28 Apr 2009 13:06:05 +0900 |
| |
blk_get_request() always returns properly zeroed requests. Don't set fields to zero/NULL unnecessarily.
[ Impact: cleanup ]
Signed-off-by: Tejun Heo <tj@kernel.org> --- block/scsi_ioctl.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index bb9aa43..58cf456 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -500,8 +500,6 @@ static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk, rq = blk_get_request(q, WRITE, __GFP_WAIT); rq->cmd_type = REQ_TYPE_BLOCK_PC; - rq->data_len = 0; - rq->extra_len = 0; rq->timeout = BLK_DEFAULT_SG_TIMEOUT; rq->cmd[0] = cmd; rq->cmd[4] = data; -- 1.6.0.2
| |