Messages in this thread | | | Date | Wed, 29 Apr 2009 00:36:19 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] ptrace: s/parent/real_parent/ in binfmt_elf_fdpic.c |
| |
On 04/29, Oleg Nesterov wrote: > > - prstatus->pr_ppid = task_pid_vnr(p->parent); > + prstatus->pr_ppid = task_pid_vnr(p->real_parent); > prstatus->pr_pgrp = task_pgrp_vnr(p);
Hmm. Just noticed. What protects ->parent or ->real_parent ?
Looks like we need rcu_lock() around... The same in fs/binfmt_elf.c. Will send another trivial patch (on top of this) tomorrow.
Oleg.
| |