lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] x86 mmiotrace: code consistency/legibility improvement
    Date
    kmmio_probe being *p and kmmio_fault_page being sometimes *f and
    sometimes *p is not helpful

    Signed-off-by: Stuart Bennett <stuart@freedesktop.org>
    Acked-by: Pekka Paalanen <pq@iki.fi>
    ---
    arch/x86/mm/kmmio.c | 34 +++++++++++++++++-----------------
    1 files changed, 17 insertions(+), 17 deletions(-)

    diff --git a/arch/x86/mm/kmmio.c b/arch/x86/mm/kmmio.c
    index 50dc802..6db840e 100644
    --- a/arch/x86/mm/kmmio.c
    +++ b/arch/x86/mm/kmmio.c
    @@ -97,13 +97,13 @@ static struct kmmio_probe *get_kmmio_probe(unsigned long addr)
    static struct kmmio_fault_page *get_kmmio_fault_page(unsigned long page)
    {
    struct list_head *head;
    - struct kmmio_fault_page *p;
    + struct kmmio_fault_page *f;

    page &= PAGE_MASK;
    head = kmmio_page_list(page);
    - list_for_each_entry_rcu(p, head, list) {
    - if (p->page == page)
    - return p;
    + list_for_each_entry_rcu(f, head, list) {
    + if (f->page == page)
    + return f;
    }
    return NULL;
    }
    @@ -439,12 +439,12 @@ static void rcu_free_kmmio_fault_pages(struct rcu_head *head)
    head,
    struct kmmio_delayed_release,
    rcu);
    - struct kmmio_fault_page *p = dr->release_list;
    - while (p) {
    - struct kmmio_fault_page *next = p->release_next;
    - BUG_ON(p->count);
    - kfree(p);
    - p = next;
    + struct kmmio_fault_page *f = dr->release_list;
    + while (f) {
    + struct kmmio_fault_page *next = f->release_next;
    + BUG_ON(f->count);
    + kfree(f);
    + f = next;
    }
    kfree(dr);
    }
    @@ -453,19 +453,19 @@ static void remove_kmmio_fault_pages(struct rcu_head *head)
    {
    struct kmmio_delayed_release *dr =
    container_of(head, struct kmmio_delayed_release, rcu);
    - struct kmmio_fault_page *p = dr->release_list;
    + struct kmmio_fault_page *f = dr->release_list;
    struct kmmio_fault_page **prevp = &dr->release_list;
    unsigned long flags;

    spin_lock_irqsave(&kmmio_lock, flags);
    - while (p) {
    - if (!p->count) {
    - list_del_rcu(&p->list);
    - prevp = &p->release_next;
    + while (f) {
    + if (!f->count) {
    + list_del_rcu(&f->list);
    + prevp = &f->release_next;
    } else {
    - *prevp = p->release_next;
    + *prevp = f->release_next;
    }
    - p = p->release_next;
    + f = f->release_next;
    }
    spin_unlock_irqrestore(&kmmio_lock, flags);

    --
    1.5.4.4


    \
     
     \ /
      Last update: 2009-04-28 21:33    [W:0.031 / U:0.860 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site