lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] lockd: fix FILE_LOCKING=n build error
    From
    On Tue, Apr 28, 2009 at 08:22:50AM -0700, Randy Dunlap wrote:
    > From: Randy Dunlap <randy.dunlap@oracle.com>
    >
    > lockd/svclock.c is missing a header file <linux/fs.h>.
    >
    > <linux/fs.h> is missing a definition of locks_release_private()
    > for the config case of FILE_LOCKING=n, causing a build error:
    >
    > fs/lockd/svclock.c:330: error: implicit declaration of function 'locks_release_private'

    LOCKD without FILE_LOCKING doesn't really make sense; would it be better
    to add a config dependency?

    --b.

    >
    > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
    > ---
    > fs/lockd/svclock.c | 1 +
    > include/linux/fs.h | 4 ++++
    > 2 files changed, 5 insertions(+)
    >
    > --- linux-next-20090428.orig/fs/lockd/svclock.c
    > +++ linux-next-20090428/fs/lockd/svclock.c
    > @@ -22,6 +22,7 @@
    >
    > #include <linux/types.h>
    > #include <linux/errno.h>
    > +#include <linux/fs.h>
    > #include <linux/kernel.h>
    > #include <linux/sched.h>
    > #include <linux/smp_lock.h>
    > --- linux-next-20090428.orig/include/linux/fs.h
    > +++ linux-next-20090428/include/linux/fs.h
    > @@ -1183,6 +1183,10 @@ static inline void locks_remove_flock(st
    > return;
    > }
    >
    > +static inline void locks_release_private(struct file_lock *fl)
    > +{
    > +}
    > +
    > static inline void posix_test_lock(struct file *filp, struct file_lock *fl)
    > {
    > return;
    >
    > --
    > ~Randy
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html


    \
     
     \ /
      Last update: 2009-04-28 19:27    [W:0.749 / U:1.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site