lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] mg_disk: fix CONFIG_LBD=y warning
    Tejun Heo wrote:
    > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    >
    > drivers/block/mg_disk.c: In function ‘mg_dump_status’:
    > drivers/block/mg_disk.c:265: warning: format ‘%ld’ expects type ‘long int’, but
    > argument 2 has type ‘sector_t’
    >
    > [ Impact: kill build warning ]
    >
    > Cc: unsik Kim <donari75@gmail.com>
    > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
    > Signed-off-by: Tejun Heo <tj@kernel.org>
    > ---
    > drivers/block/mg_disk.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/block/mg_disk.c b/drivers/block/mg_disk.c
    > index d3e72ad..f389835 100644
    > --- a/drivers/block/mg_disk.c
    > +++ b/drivers/block/mg_disk.c
    > @@ -79,7 +79,7 @@ static void mg_dump_status(const char *msg, unsigned int stat,
    > if (host->breq) {
    > req = elv_next_request(host->breq);
    > if (req)
    > - printk(", sector=%ld", req->sector);
    > + printk(", sector=%u", (u32)req->sector);
    ..

    Eh? Shouldn't that be fixed the other way around, like this:

    + printk(", sector=%llu", (u64)req->sector);

    This way, it will still give correct data when sector_t is a u64.

    ???
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-28 17:23    [W:0.044 / U:1.496 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site