lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [spi-devel-general] [PATCH v2] spi: Add support for the OpenCores SPI controller.
* Thierry Reding wrote:
> This patch adds a platform device driver that supports the OpenCores SPI
> controller.
>
> The driver expects two resources: an IORESOURCE_MEM resource defining the
> core's memory-mapped registers and an IORESOURCE_IRQ for the associated
> interrupt. It also requires a clock, "spi-master-clk", used to compute the
> clock divider.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
[snip]

This second version is pretty much a rewrite. Some notes about the most
important changes:

* uses per-chip states to allow more slaves to use the controller
concurrently
* rejects invalid device configurations during setup
* rejects invalid per-message and per-transfer options
* queues messages so that they can be processed one after another
- this also provides for a way to handle power-management
* omits the spioc.h (and with it the platform data structure):
- uses the platform_device.id for the bus number
- always uses 8 chipselects because that's the maximum that the core
supports

I couldn't really find a way to implement per-transfer overrides for the
word size because the controller simply has no concept of word sizes. Is it
in such cases still necessary to hardwire the word size to 8 bits?

Thierry



\
 
 \ /
  Last update: 2009-04-28 13:19    [W:3.126 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site