lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/9] x86/irq: make MSI irq_desc numa aware -v3

* Yinghai Lu <yinghai@kernel.org> wrote:

> +#ifdef CONFIG_NUMA_IRQ_DESC
> + /* different node ?*/
> + if (desc_new->node != node)
> + desc = move_irq_desc(desc, node);
> +#endif

this should have been CONFIG_NUMA_MIGRATE_IRQ_DESC. But even with
that fixed, CONFIG_NUMA_MIGRATE_IRQ_DESC is _removed_ in the #2
patch in your series and never reintroduced!

I've fixed these two bugs in the series and i'm thinking about
applying them, but this really makes me think how much testing
you've put into this code.

You really should check that the feature actually does what you
think, that it can be enabled and you should also check the
before/after layout of irq descriptors on a NUMA box.

Ingo


\
 
 \ /
  Last update: 2009-04-28 12:25    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site