lkml.org 
[lkml]   [2009]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/14] swim: clean up request completion paths
    Date
    swim curiously tries to update request parameters before calling
    __blk_end_request() when __blk_end_request() will do it anyway and
    unnecessarily checks whether current_nr_sectors is zero right after
    fetching.

    Drop unnecessary stuff and use standard block layer mechanisms.

    [ Impact: cleanup ]

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Cc: Laurent Vivier <Laurent@lvivier.info>
    ---
    drivers/block/swim.c | 7 -------
    1 files changed, 0 insertions(+), 7 deletions(-)

    diff --git a/drivers/block/swim.c b/drivers/block/swim.c
    index 6544a7b..97ef426 100644
    --- a/drivers/block/swim.c
    +++ b/drivers/block/swim.c
    @@ -535,10 +535,6 @@ static void redo_fd_request(struct request_queue *q)
    __blk_end_request_cur(req, -EIO);
    continue;
    }
    - if (req->current_nr_sectors == 0) {
    - __blk_end_request_cur(req, 0);
    - continue;
    - }
    if (!fs->disk_in) {
    __blk_end_request_cur(req, -EIO);
    continue;
    @@ -561,9 +557,6 @@ static void redo_fd_request(struct request_queue *q)
    __blk_end_request_cur(req, -EIO);
    continue;
    }
    - req->nr_sectors -= req->current_nr_sectors;
    - req->sector += req->current_nr_sectors;
    - req->buffer += req->current_nr_sectors * 512;
    __blk_end_request_cur(req, 0);
    break;
    }
    --
    1.6.0.2


    \
     
     \ /
      Last update: 2009-04-28 06:15    [W:0.024 / U:60.264 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site