Messages in this thread | | | Date | Tue, 28 Apr 2009 12:44:07 +0900 | From | Tejun Heo <> | Subject | Re: [RFC PATCHSET linux-2.6-block#for-2.6.31] block: lld cleanup patches |
| |
Hello, Bartlomiej.
Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [RFC][PATCH] mg_disk: fix issue with data integrity on error in mg_write() > > We cannot acknowledge the sector write before checking its status > (which is done on the next loop iteration) and we also need to do > the final status register check after writing the last sector. > > Fix mg_write() to match mg_write_intr() in this regard. > > While at it: > - add mg_read_one() and mg_write_one() helpers > - always use MG_SECTOR_SIZE and remove MG_STORAGE_BUFFER_SIZE > > Cc: unsik Kim <donari75@gmail.com> > Cc: Tejun Heo <tj@kernel.org> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
I folded other three patches into my series. This one looks good to me too but unlike others this one actually changes how the driver interacts with the device so I think it would be better to wait for unsik's ack on this one (I'm pushing out others).
Thanks.
-- tejun
| |