Messages in this thread Patch in this message | | | From | David Howells <> | Subject | [PATCH] FRV: utrace: Miscellaneous fixes | Date | Tue, 28 Apr 2009 00:28:33 +0100 |
| |
Fixes for the FRV utrace/tracehook code:
(1) Macro task_pt_regs()'s argument should be bracketed when used.
(2) The dest data pointer for user_regset_copyin() should point to the place at which the data at position start_pos begins.
Signed-off-by: David Howells <dhowells@redhat.com> ---
arch/frv/include/asm/ptrace.h | 2 +- arch/frv/kernel/ptrace.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/frv/include/asm/ptrace.h b/arch/frv/include/asm/ptrace.h index 5f8b5e4..a54b535 100644 --- a/arch/frv/include/asm/ptrace.h +++ b/arch/frv/include/asm/ptrace.h @@ -81,7 +81,7 @@ extern unsigned long user_stack(const struct pt_regs *); extern void show_regs(struct pt_regs *); #define profile_pc(regs) ((regs)->pc) -#define task_pt_regs(task) (task->thread.frame0) +#define task_pt_regs(task) ((task)->thread.frame0) #define arch_has_single_step() (1) extern void user_enable_single_step(struct task_struct *); diff --git a/arch/frv/kernel/ptrace.c b/arch/frv/kernel/ptrace.c index e847945..60eeed3 100644 --- a/arch/frv/kernel/ptrace.c +++ b/arch/frv/kernel/ptrace.c @@ -92,7 +92,7 @@ static int genregs_set(struct task_struct *target, /* set the general regs */ ret = user_regset_copyin(&pos, &count, &kbuf, &ubuf, - iregs, offs_gr1, sizeof(*iregs)); + &iregs->gr[1], offs_gr1, sizeof(*iregs)); if (ret < 0) return ret;
| |