Messages in this thread | | | Date | Mon, 27 Apr 2009 20:37:38 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH 2/8] frv: Use __INIT macro instead of .text.init. |
| |
On Mon, Apr 27, 2009 at 02:02:21PM -0400, Tim Abbott wrote: > frv is placing some code in the .text.init section but does not > reference that section in its linker scripts. > > This change moves this code from the .text.init section to the > .init.text section, which is presumably where it belongs.
I checked a few of the assembler entries - they where all called from __HEAD section. So this change looks good.
> > Signed-off-by: Tim Abbott <tabbott@mit.edu> > Cc: David Howells <dhowells@redhat.com> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> --- > arch/frv/kernel/head-mmu-fr451.S | 3 ++- > arch/frv/kernel/head-uc-fr401.S | 3 ++- > arch/frv/kernel/head-uc-fr451.S | 3 ++- > arch/frv/kernel/head-uc-fr555.S | 3 ++- > 4 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/frv/kernel/head-mmu-fr451.S b/arch/frv/kernel/head-mmu-fr451.S > index c8f210d..98f87d5 100644 > --- a/arch/frv/kernel/head-mmu-fr451.S > +++ b/arch/frv/kernel/head-mmu-fr451.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include <linux/init.h> > #include <linux/threads.h> > #include <linux/linkage.h> > #include <asm/ptrace.h> > @@ -31,7 +32,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr401.S b/arch/frv/kernel/head-uc-fr401.S > index ee282be..438643c 100644 > --- a/arch/frv/kernel/head-uc-fr401.S > +++ b/arch/frv/kernel/head-uc-fr401.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include <linux/init.h> > #include <linux/threads.h> > #include <linux/linkage.h> > #include <asm/ptrace.h> > @@ -30,7 +31,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr451.S b/arch/frv/kernel/head-uc-fr451.S > index b10d9c8..b2a76c4 100644 > --- a/arch/frv/kernel/head-uc-fr451.S > +++ b/arch/frv/kernel/head-uc-fr451.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include <linux/init.h> > #include <linux/threads.h> > #include <linux/linkage.h> > #include <asm/ptrace.h> > @@ -30,7 +31,7 @@ > #define __400_LCR 0xfe000100 > #define __400_LSBR 0xfe000c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > diff --git a/arch/frv/kernel/head-uc-fr555.S b/arch/frv/kernel/head-uc-fr555.S > index 39937c1..5497aaf 100644 > --- a/arch/frv/kernel/head-uc-fr555.S > +++ b/arch/frv/kernel/head-uc-fr555.S > @@ -9,6 +9,7 @@ > * 2 of the License, or (at your option) any later version. > */ > > +#include <linux/init.h> > #include <linux/threads.h> > #include <linux/linkage.h> > #include <asm/ptrace.h> > @@ -29,7 +30,7 @@ > #define __551_LCR 0xfeff1100 > #define __551_LSBR 0xfeff1c00 > > - .section .text.init,"ax" > + __INIT > .balign 4 > > ############################################################################### > -- > 1.6.2.1 >
| |