lkml.org 
[lkml]   [2009]   [Apr]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 29/30] microblaze_mmu_v1: stat.h MMU update
    Christoph Hellwig wrote:
    > On Mon, Apr 27, 2009 at 10:32:18AM +0200, monstr@monstr.eu wrote:
    >> +# ifdef __uClinux__
    >> struct stat64 {
    >> unsigned long long st_dev;
    >> unsigned long __unused1;
    >> @@ -69,5 +69,29 @@ struct stat64 {
    >>
    >> unsigned long __unused8;
    >> };
    >> +# else /* __uClinux__ */
    >> +/* FIXME */
    >> +struct stat64 {
    >> + unsigned long long st_dev; /* Device.*/
    >> + unsigned long long st_ino; /* File serial number.*/
    >> + unsigned int st_mode; /* File mode.*/
    >> + unsigned int st_nlink; /* Link count. */
    >> + unsigned int st_uid; /* User ID of the file's owner. */
    >> + unsigned int st_gid; /* Group ID of the file's group. */
    >> + unsigned long long st_rdev; /* Device number, if device. */
    >> + unsigned short __pad2;
    >> + long long st_size; /* Size of file, in bytes. */
    >> + int st_blksize; /* Optimal block size for I/O. */
    >> + long long st_blocks; /* No. 512-byte blocks allocated */
    >> + int st_atime; /* Time of last access. */
    >> + unsigned int st_atime_nsec;
    >> + int st_mtime; /* Time of last modification. */
    >> + unsigned int st_mtime_nsec;
    >> + int st_ctime; /* Time of last status change. */
    >> + unsigned int st_ctime_nsec;
    >> + unsigned int __unused4;
    >> + unsigned int __unused5;
    >> +};
    >> +# endif /* __uClinux__ */
    >
    > Userspace ABIs must not change because of MMU vs not.
    >

    :-)

    I expect that someone will beat me for last two patches.

    Short answer: You are right I know about.

    Long answer: in stat64 structure I wanted to find out more information
    about stat64 structure. I mean there are some variables and they have different
    types and I would like to know about more info.
    For example
    If make sense long long type for st_blocks. IMHO unsigned will be better.
    And I would like to create new stat64 structure where is not a fault for both noMMU/MMU version.
    In noMMU implementation is st_blocks unsigned long. Is it OK? or unsigned long long is better?

    Thanks,
    Michal

    --
    Michal Simek, Ing. (M.Eng)
    w: www.monstr.eu p: +42-0-721842854


    \
     
     \ /
      Last update: 2009-04-27 12:39    [W:0.022 / U:93.820 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site