lkml.org 
[lkml]   [2009]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 1/3] Make section names compatible with -ffunction-sections -fdata-sections
    Date
    On Sat, 25 Apr 2009 02:53:58 am Sam Ravnborg wrote:
    > > ---
    > > Documentation/mutex-design.txt | 4 +-
    > > arch/alpha/kernel/head.S | 2 +-
    > ...
    > > include/linux/linkage.h | 4 +-
    > > include/linux/spinlock.h | 2 +-
    > > kernel/module.c | 2 +-
    > > scripts/mod/modpost.c | 12 ++++----
    > > scripts/recordmcount.pl | 6 ++--
    > > 141 files changed, 356 insertions(+), 348 deletions(-)
    >
    > This patch touches far too many files.
    > We should try to work out a method so we are in better control
    > of the section names, so renaming in the end is a simple patch
    > touching only a few files.

    Completely disagree. You'll end up touching all these files, and leaving
    us with now-unnecessary a level of indirection. Also, you'll have performed
    a giant pile of make-work, and bothered all the maintainers.

    Just get Linus to apply the damn patch already; it's been sitting around too
    long. Then do any cleanups which are actual cleanups.

    Rusty.


    \
     
     \ /
      Last update: 2009-04-26 15:11    [W:3.574 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site