lkml.org 
[lkml]   [2009]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] tracing/events: make modules have their own file_operations structure
On Sat, Apr 25, 2009 at 12:20:35AM -0400, Steven Rostedt wrote:
> From: Steven Rostedt <srostedt@redhat.com>
>
> For proper module reference counting, the file_operations that modules use
> must have the "owner" field set to the module. Unfortunately, the trace events
> use share file_operations. The same file_operations are used by all both
> kernel core and all modules.
>
> This patch makes the modules allocate their own file_operations and
> copies the functions from the core kernel. This allows those file
> operations to be owned by the module.
>
> Care is taken to free this code on module unload.
>
> Thanks to Greg KH for reminding me that file_operations must be owned
> by the module to have reference counting take place.
>
> Cc: Greg KH <greg@kroah.com>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Looks good, feel free to add an:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to it.

thanks,

greg k-h


\
 
 \ /
  Last update: 2009-04-25 19:33    [W:0.072 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site