lkml.org 
[lkml]   [2009]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
From
On Fri, 24 Apr 2009 21:41:17 +0200, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > RTC alarm interrupt handler takes rtc->irq_lock by spin_lock()
> > > 2. A timer interrupt handler calls rtc_uie_timer() for UIE emulation
> > > 3. rtc_uie_timer() waits on rtc->irq_lock .... deadlock!
> >
> > Oops, this is wrong. This deadlock cannot happen since
> > rtc_uie_timer() will be called in bh (softirq) context, not interrupt
> > context.
>
> Correct.
>
> And we have only one irq handler per driver. Anything else?

Some drivers (omap, pxa, etc.) have multiple irq handler. Currently
all such drivers use IRQF_DISABLED so I do not see any real problem
now.

So I think my patch is rather "cleanup and bulletproof" than "bugfix".

---
Atsushi Nemoto

\
 
 \ /
  Last update: 2009-04-25 14:43    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site