lkml.org 
[lkml]   [2009]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] fsldma: use PCI Read Multiple command
    By default, the Freescale 83xx DMA controller uses the PCI Read Line
    command when reading data over the PCI bus. Setting the controller to use
    the PCI Read Multiple command instead allows the controller to read much
    larger bursts of data, which provides a drastic speed increase.

    The slowdown due to using PCI Read Line was only observed when a PCI-to-PCI
    bridge was between the devices trying to communicate.

    A simple test driver showed an increase from 4MB/sec to 116MB/sec when
    performing DMA over the PCI bus. Using DMA to transfer between blocks of
    local SDRAM showed no change in performance with this patch. The dmatest
    driver was also used to verify the correctness of the transfers, and showed
    no errors.

    Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
    ---
    drivers/dma/fsldma.c | 5 +++--
    drivers/dma/fsldma.h | 1 +
    2 files changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
    index da8a8ed..638d00e 100644
    --- a/drivers/dma/fsldma.c
    +++ b/drivers/dma/fsldma.c
    @@ -49,9 +49,10 @@ static void dma_init(struct fsl_dma_chan *fsl_chan)
    case FSL_DMA_IP_83XX:
    /* Set the channel to below modes:
    * EOTIE - End-of-transfer interrupt enable
    + * PRC_RM - PCI read multiple
    */
    - DMA_OUT(fsl_chan, &fsl_chan->reg_base->mr, FSL_DMA_MR_EOTIE,
    - 32);
    + DMA_OUT(fsl_chan, &fsl_chan->reg_base->mr, FSL_DMA_MR_EOTIE
    + | FSL_DMA_MR_PRC_RM, 32);
    break;
    }

    diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
    index 4f21a51..dc7f268 100644
    --- a/drivers/dma/fsldma.h
    +++ b/drivers/dma/fsldma.h
    @@ -38,6 +38,7 @@

    /* Special MR definition for MPC8349 */
    #define FSL_DMA_MR_EOTIE 0x00000080
    +#define FSL_DMA_MR_PRC_RM 0x00000800

    #define FSL_DMA_SR_CH 0x00000020
    #define FSL_DMA_SR_PE 0x00000010
    --
    1.5.4.3


    \
     
     \ /
      Last update: 2009-04-24 20:37    [W:2.355 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site