lkml.org 
[lkml]   [2009]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build
On Thu, Apr 23, 2009 at 01:58:46PM +0200, Jesper Nilsson wrote:
> >
> > #ifdef WANT_WARN_ON_SLOWPATH
> > -void warn_slowpath(const char *file, int line, const char *fmt, ...)
> > +void warn_slowpath_fmt(const char *file, int line, const char *fmt, ...)
> > {
> > va_list args;
> > char function[KSYM_SYMBOL_LEN];
> > @@ -358,7 +358,7 @@
> > if (board)
> > printk(KERN_WARNING "Hardware name: %s\n", board);
> >
> > - if (fmt) {
> > + if (*fmt) {
>
> Is this completely safe? If somebody is stupid enough to call
> WARN(condition, NULL); this won't work as it did before.
> OTOH, it would still be useless in debugging...

Noone in tree does according to grep. I would also argue
anyone doing that to be really broken.

>
> Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>

Thanks.

-Andi
--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-04-23 14:17    [W:0.061 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site