Messages in this thread | | | Date | Wed, 22 Apr 2009 19:08:24 -0700 | From | Greg KH <> | Subject | Re: staging: comedi: non working tests on unsigned cmd->convert_arg |
| |
On Wed, Apr 22, 2009 at 02:11:10PM -0400, Frank Mori Hess wrote: > On Wednesday 22 April 2009, Greg KH wrote: > > On Tue, Apr 21, 2009 at 03:18:10PM +0200, Roel Kluin wrote: > > > vi drivers/staging/comedi/comedi.h +342 > > > > > > and note that cmd->convert_arg in s626_ai_cmdtest() is unsigned. > > > Should there maybe be a test: > > > > > > if (cmd->convert_src == TRIG_EXT && cmd->convert_arg > MAX) > > > > > > (and what should MAX be then?) > > > > I don't know. Let's ask the comedi developers :) > > > > Frank, what do you think about this? > > > It looks like there already is such a test, right below the useless one the > patch removes.
Ok, thanks for checking. Roel, care to resend these patches then?
thanks,
greg k-h
| |