Messages in this thread | | | Date | Wed, 22 Apr 2009 15:08:52 -0700 | From | Jesse Barnes <> | Subject | Re: [PATCH] x86/pci: do assign root bus res if _CRS is used |
| |
On Mon, 20 Apr 2009 18:35:40 -0700 Yinghai Lu <yinghai@kernel.org> wrote:
> > it wil be overwriten later if _CRS is used, so don't bother to set it. > > [ Impact: cleanup ]
Applied, thanks.
A general comment on your patches though: please spent a few more minutes coming up with readable & useful summaries & changelogs. Most of the time when applying your patches (which are generally fine technically) I have to delete the whole changelog and come up with a new one based on reading the sources and then your patch. It would be nice if I didn't have to. Grammar and spelling mistakes are fine (I usually catch those) but when the logic of the changelog is all wrong, or it doesn't describe what it's doing and why, it makes things much more difficult.
Thanks, -- Jesse Barnes, Intel Open Source Technology Center
| |