Messages in this thread | | | Date | Wed, 22 Apr 2009 09:50:49 -0700 | From | Greg KH <> | Subject | Re: staging: comedi: non working tests on unsigned cmd->convert_arg |
| |
On Tue, Apr 21, 2009 at 03:18:10PM +0200, Roel Kluin wrote: > vi drivers/staging/comedi/comedi.h +342 > > and note that cmd->convert_arg in s626_ai_cmdtest() is unsigned. Should there > maybe be a test: > > if (cmd->convert_src == TRIG_EXT && cmd->convert_arg > MAX) > > (and what should MAX be then?)
I don't know. Let's ask the comedi developers :)
Frank, what do you think about this?
> Otherwise you may want to apply the cleanup patch below > > Roel > ------------------------------>8-------------8<--------------------------------- > Remove redundant tests on unsigned > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > diff --git a/drivers/staging/comedi/drivers/s626.c b/drivers/staging/comedi/drivers/s626.c > index 30dec9d..928c4c6 100644 > --- a/drivers/staging/comedi/drivers/s626.c > +++ b/drivers/staging/comedi/drivers/s626.c > @@ -1906,7 +1906,7 @@ static int s626_ai_cmdtest(struct comedi_device *dev, struct comedi_subdevice *s > err++; > } > > - if (cmd->convert_src == TRIG_EXT && cmd->convert_arg < 0) { > + if (cmd->convert_src == TRIG_EXT) { > cmd->convert_arg = 0; > err++; > }
| |