lkml.org 
[lkml]   [2009]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 25/25] Use a pre-calculated value instead of num_online_nodes() in fast paths
    From
    Date
    On Mon, 2009-04-20 at 23:20 +0100, Mel Gorman wrote:
    > diff --git a/mm/slab.c b/mm/slab.c
    > index 1c680e8..41d1343 100644
    > --- a/mm/slab.c
    > +++ b/mm/slab.c
    > @@ -3579,7 +3579,7 @@ static inline void __cache_free(struct kmem_cache *cachep, void *objp)
    > * variable to skip the call, which is mostly likely to be present in
    > * the cache.
    > */
    > - if (numa_platform && cache_free_alien(cachep, objp))
    > + if (numa_platform > 1 && cache_free_alien(cachep, objp))
    > return;

    This doesn't look right. I assume you meant "nr_online_nodes > 1" here?
    If so, please go ahead and remove "numa_platform" completely.




    \
     
     \ /
      Last update: 2009-04-21 10:13    [W:0.028 / U:0.276 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site