lkml.org 
[lkml]   [2009]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [ltt-dev] [PATCH] nfs: add support for splice writes
    On Mon, Apr 20, 2009 at 09:17:23PM +0530, Suresh Jayaraman wrote:
    > +static ssize_t nfs_file_splice_write(struct pipe_inode_info *pipe,
    > + struct file *filp, loff_t *ppos,
    > + size_t count, unsigned int flags)
    > +{
    > + struct dentry *dentry = filp->f_path.dentry;
    > +
    > + dprintk("NFS splice_write(%s/%s, %lu@%Lu)\n",
    > + dentry->d_parent->d_name.name, dentry->d_name.name,
    > + (unsigned long) count, (unsigned long long) *ppos);
    > +
    > + return generic_file_splice_write(pipe, filp, ppos, count, flags);
    > +}
    > +

    You need all calls from nfs_file_write, too:

    - most importantly the nfs_revalidate_file_size for O_APPEND
    - the nfs_do_fsync for sync writes
    - probably the stats increment


    \
     
     \ /
      Last update: 2009-04-21 16:51    [W:0.020 / U:30.308 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site