Messages in this thread | | | Date | Tue, 21 Apr 2009 12:16:19 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter |
| |
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> Ingo Molnar wrote: > > * Li Zefan <lizf@cn.fujitsu.com> wrote: > > > >> Ingo Molnar wrote: > >>> * Li Zefan <lizf@cn.fujitsu.com> wrote: > >>> > >>>> I guess because user input is often ended with '\n' (like "echo > >>>> xxx"), thus '\n' is used as a delimeter besides ' ', but we can > >>>> just strip tailing spaces. > >>> Hm, how about: > >>> > >>> ( echo 'x' > >>> echo '|| y' ) > filter > >>> > >>> type of scripts? Shouldnt the parser be permissive in general? > >>> > >> This patch doesn't forbid this usage: ;) > >> > >> ( echo 'parent_comm == a' > >> echo '|| parent_comm == b' ) > filter > >> > >> This patch does forbid this usage: > >> > >> ( echo 'parent_comm' > >> echo '==' > >> echo 'a' ) > filter > > > > Same argument though, no? > > > > Then I have no strong opinion on this. I'm fine to drop this patch.
I've applied the other two - no strong opinion either about this patch. Tom, what do you think? (there's also some new parser in the works i suspect)
Ingo
| |