Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 14/25] Inline buffered_rmqueue() | Date | Tue, 21 Apr 2009 18:56:00 +0900 (JST) |
| |
> buffered_rmqueue() is in the fast path so inline it. Because it only has > one call site, this actually should reduce text bloat instead of > increase it.
nit: please append size command output.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: Mel Gorman <mel@csn.ul.ie> > --- > mm/page_alloc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 91a2cdb..2dfe3aa 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1077,7 +1077,8 @@ void split_page(struct page *page, unsigned int order) > * we cheat by calling it from here, in the order > 0 path. Saves a branch > * or two. > */ > -static struct page *buffered_rmqueue(struct zone *preferred_zone, > +static inline > +struct page *buffered_rmqueue(struct zone *preferred_zone, > struct zone *zone, int order, gfp_t gfp_flags, > int migratetype, int cold) > { > -- > 1.5.6.5 >
| |