lkml.org 
[lkml]   [2009]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] fbdev: fix fillrect for 24bpp modes
    On Sat, 18 Apr 2009 20:52:34 +0200
    Michal Januszewski <spock@gentoo.org> wrote:

    > The software fillrect routines do not work properly when the number of
    > pixels per machine word is not an integer. To see that, run the following
    > command on a fbdev console with a 24bpp video mode, using a non-accelerated
    > driver such as (u)vesafb:
    >
    > reset ; echo -e '\e[41mtest\e[K'
    >
    > The expected result is 'test' displayed on a line with red background.
    > Instead of that, 'test' has a red background, but the rest of the line
    > (rendered using fillrect()) contains a distored colorful pattern.
    >
    > This patch fixes the problem by correctly computing rotation shifts.
    > It has been tested in a 24bpp mode on 32- and 64-bit little-endian
    > machines.
    >
    > Signed-off-by: Michał Januszewski <spock@gentoo.org>
    > ---

    I have tested the patch and it has worked with padded lines.

    Acked-by: Krzysztof Helt <krzysztof.h1@wp.pl>

    However, there is a comment from Andrew Morton.

    Regards,
    Krzysztof

    ----------------------------------------------------------------------
    Gotowka na koncie. Otworz konto direct i wez podwojny limit.
    http://link.interia.pl/f2115


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-21 07:09    [W:0.030 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site