lkml.org 
[lkml]   [2009]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [microblaze-uclinux] [PATCH] microblaze: iowrite upon timeout
    From
    On Fri, Apr 17, 2009 at 6:49 AM, Roel Kluin <roel.kluin@gmail.com> wrote:
    > retries reaches -1, so the iowrite occurrs upon timeout.
    >
    > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>

    Acked-by: John Williams <john.williams@petalogix.com>

    (also applied to PetaLogix SVN)

    Thanks,

    John

    > ---
    > diff --git a/arch/microblaze/kernel/early_printk.c b/arch/microblaze/kernel/early_printk.c
    > index 62cc789..4b0f0fd 100644
    > --- a/arch/microblaze/kernel/early_printk.c
    > +++ b/arch/microblaze/kernel/early_printk.c
    > @@ -36,7 +36,7 @@ static void early_printk_putc(char c)
    >
    >        unsigned retries = 10000;
    >        /* read status bit - 0x8 offset */
    > -       while (retries-- && (in_be32(base_addr + 8) & (1 << 3)))
    > +       while (--retries && (in_be32(base_addr + 8) & (1 << 3)))
    >                ;
    >
    >        /* Only attempt the iowrite if we didn't timeout */
    > ___________________________
    > microblaze-uclinux mailing list
    > microblaze-uclinux@itee.uq.edu.au
    > Project Home Page : http://www.itee.uq.edu.au/~jwilliams/mblaze-uclinux
    > Mailing List Archive : http://www.itee.uq.edu.au/~listarch/microblaze-uclinux/
    >
    >



    --
    John Williams, PhD, B.Eng, B.IT
    PetaLogix - Linux Solutions for a Reconfigurable World
    w: www.petalogix.com p: +61-7-30090663 f: +61-7-30090663
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-04-21 03:21    [W:0.035 / U:0.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site