Messages in this thread | | | Date | Mon, 20 Apr 2009 14:26:40 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 3/3] crypto: add self-tests for rfc4309(ccm(aes)) |
| |
On Wed, Apr 15, 2009 at 09:37:11AM -0400, Jarod Wilson wrote: > Add an array of encryption and decryption + verification self-tests > for rfc4309(ccm(aes)). > > Test vectors all come from sample FIPS CAVS files provided to > Red Hat by a testing lab. Unfortunately, all the published sample > vectors in RFC 3610 and NIST Special Publication 800-38C contain nonce > lengths that the kernel's rfc4309 implementation doesn't support, so > while using some public domain vectors would have been preferred, its > not possible at this time. > > Signed-off-by: Jarod Wilson <jarod@redhat.com>
This one looks good to me. So if you just drop patch 1 (unless there's something I'm missing), change patch 2 to use continue and resubmit, then I'll put them in cryptodev.
Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |