Messages in this thread | | | Date | Mon, 20 Apr 2009 05:08:04 -0600 | From | Matthew Wilcox <> | Subject | Re: [PATCH 2/2] pci, msi: Define PCI_MSI_MASK_32/64 |
| |
On Mon, Apr 20, 2009 at 10:54:59AM +0900, Hidetoshi Seto wrote: > Impact: cleanup, improve readability > > Define PCI_MSI_MASK_32/64 for 32/64bit devices, instead of using > implicit offset (-4), "PCI_MSI_MASK_BIT - 4" and "PCI_MSI_MASK_BIT". > > Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Yes, nice cleanup.
Reviewed-by: Matthew Wilcox <willy@linux.intel.com>
-- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."
| |