lkml.org 
[lkml]   [2009]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management [ver #46]
From
Date
On Thu, 2009-04-02 at 18:40 +0100, David Howells wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> > Well in theory I still think it would be cleanest to modify buffer to
> > play more nicely with it. But maybe that ends up being harder to
> > distinguish the 3 cases of attached metadata on the page. I don't know,
> > you haven't posted any isofs code so either way it is inappropriate to
> > use up this extra page flag here.
> >
> > Is isofs cache worth a page flag?
>
> Well, isofs was something I wanted at the time.
>
> Besides, as I said NFS uses PG_private for its own purposes, and entangling
> the two wasn't the most fun I've had. Trond didn't like it either.

We use it for exactly the same purpose as everyone else: to signal that
we need a callback to ->releasepage() if the VM wants to truncate the
page.

Trond



\
 
 \ /
  Last update: 2009-04-02 21:23    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site