lkml.org 
[lkml]   [2009]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT] kbuild
On Sun, Apr 19, 2009 at 05:52:32PM -0700, Linus Torvalds wrote:
>
>
> On Mon, 20 Apr 2009, Sam Ravnborg wrote:
> >
> > You will soon see a path from me where I fix sh too.
>
> Can we do a global 'sed s:asm/asm-offsets.h:generated/asm-offsets.h:g'
> thing too? And then get rid of the include/asm symlink?
>
> That asm-offsets.h mess is scary. I don't quite know why kvm on ia64 seems
> to do it's own asm-offsets.h file, for example. And arch/blackfin/Makefile
> mentions arch/$(ARCH)/include/asm/asm-offsets.h (but does it actually do
> one?).

We'll need to update uml as well (contents of shared/kern_constants.h)

As for the arch/ia64/kvm/asm-offsets, AFAICS that could go straight into
arch/ia64/kernel/asm-offsets.c, under ifdef CONFIG_KVM.

I'm not sure about sed job, BTW - might be better to start with
arch/*/include/asm/asm-offsets.h containing just one include, then
do the transition you want piece by piece. And then kill these
files as corresponding architectures lose the last unconverted includes.
Fewer merge conflicts with the stuff in architecture trees that way and the
final result will be exactly the same...


\
 
 \ /
  Last update: 2009-04-20 03:45    [from the cache]
©2003-2011 Jasper Spaans