lkml.org 
[lkml]   [2009]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] pci: don't printout if the bus res size is 0

* Yinghai Lu <yinghai@kernel.org> wrote:

>
> also print out if it is prefetechable mmio
>
> [Impact: cleanup]
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> drivers/pci/setup-bus.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/pci/setup-bus.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/setup-bus.c
> +++ linux-2.6/drivers/pci/setup-bus.c
> @@ -558,11 +558,13 @@ static void pci_bus_dump_res(struct pci_
>
> for (i = 0; i < PCI_BUS_NUM_RESOURCES; i++) {
> struct resource *res = bus->resource[i];
> - if (!res)
> + if (!res || !res->end)
> continue;
>
> dev_printk(KERN_DEBUG, &bus->dev, "resource %d %s %pR\n", i,
> - (res->flags & IORESOURCE_IO) ? "io: " : "mem:", res);
> + (res->flags & IORESOURCE_IO) ? "io: " :
> + ((res->flags & IORESOURCE_PREFETCH)? "pref mem":"mem:"),
> + res);

'pref mem' is easily mistaken for 'preferential memory' or something
similar. Would printing "prefetchable-mem" still be OK?

Ingo


\
 
 \ /
  Last update: 2009-04-18 11:19    [W:0.199 / U:0.628 seconds]
©2003-2014 Jasper Spaans. Advertise on this site